remove unused dependencies#9999
Merged
braingram merged 1 commit intospacetelescope:mainfrom Nov 7, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9999 +/- ##
==========================================
+ Coverage 85.45% 85.52% +0.07%
==========================================
Files 366 366
Lines 37845 38029 +184
==========================================
+ Hits 32341 32526 +185
+ Misses 5504 5503 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pllim
approved these changes
Nov 6, 2025
Collaborator
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
I like cleanups like this. Thanks!
Collaborator
Author
|
I restarted the CI now that spacetelescope/stcal#433 is merged and set this PR to automerge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wiimatch is unused post #9486
stsci.imagestats is used by stcal and should be a dependency there: spacetelescope/stcal#433
This won't quite work until spacetelescope/stcal#433 is merged. However since tweakwcs also incorrectly listed imagestats as a dependency (spacetelescope/tweakwcs#236) we still pull this in.
Regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/19149033220
as expect, still show stsci.imagestats and show that wiimatch is not installed
I suggest that we merge this PR at the same time as the stcal one. The reasoning is the oldestdeps job here may start complaining when the stcal PR is merged since the lower pin in stcal (1.8.3) is higher than the current jwst lower pin (1.6.3).
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files